Update show_hsrp.py #768
Open
Update show_hsrp.py #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing fails if the p9.match(line) parses the second case of your example (bfd enabled but interface unknown) hsrp_detail_dict[interface]['bfd']['enabled'] gets set in line 668 but line 669 will prevent that hsrp_detail_dict[interface]['bfd']['detection_multiplier'] & hsrp_detail_dict[interface]['bfd']['interval'] gets written. Therefore the later 2 should be optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing fails if the p9.match(line) parses the second case of your example (bfd enabled but interface unknown)
hsrp_detail_dict[interface]['bfd']['enabled'] gets set in line 668 but line 669 MAY prevent that hsrp_detail_dict[interface]['bfd']['detection_multiplier'] & hsrp_detail_dict[interface]['bfd']['interval'] gets written. Therefore the later 2 should be optional.
Description
hsrp_detail_dict[interface]['bfd']['enabled'] gets set in line 668 but line 669 will prevent that hsrp_detail_dict[interface]['bfd']['detection_multiplier'] & hsrp_detail_dict[interface]['bfd']['interval'] gets written. Therefore the later 2 should be optional.
Motivation and Context
Parsing fails if BFD is enabled on a HSRP interface in INIT State / down
Impact (If any)
Screenshots:
Checklist: